Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DotenvConfigurator, for .env.etc files #1028

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add DotenvConfigurator, for .env.etc files #1028

merged 1 commit into from
Oct 1, 2024

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 1, 2024 •
edited
Loading

@nicolas-grekas nicolas-grekas mentioned this pull request Oct 1, 2024
Merged
@fabpot
Copy link
Member

fabpot commented Oct 1, 2024

Thank you @nicolas-grekas.

@fabpot fabpot merged commit aae706c into 2.x Oct 1, 2024
2 of 3 checks passed
@fabpot fabpot deleted the dotenv-config branch October 1, 2024 11:06
@stof
Copy link
Member

stof commented Oct 1, 2024

how will this work for projects with multiple developers ? As the .env.local file is not committed, the dev running the recipe will get the change, but it will be missing for everyone else in the team.

@stof stof mentioned this pull request Oct 1, 2024
Merged
@nicolas-grekas
Copy link
Member Author

We could put that secret in .env.dev, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @stof